Optional disable of pop action on setting route #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started playing around with this router for a WatchKit app I'm going to be working on. I realised that the router could not handle back button / swipe left navigation patterns without also triggering the pop func on the Routable when dispatching a SetRouteAction on willDisappear() (similarly to the GitHubBrowserExample). This PR takes an alternative approach to solving it by specifying a disablePopAction bool on the SetRouteAction. This means the pop() isn't called but the routable is removed from the array. Seems to work well from testing on a real Apple Watch.