feat(Twitter): Add Change link sharing domain patch
#3118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
requested changes
Oct 9, 2023
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
...kotlin/app/revanced/patches/twitter/misc/fxtwitter/fingerprints/FxTwitterPatchFingerprint.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Oct 9, 2023
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
changed the title
Change link sharing domain patch
oSumAtrIX
requested changes
Oct 12, 2023
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/fxtwitter/FxTwitterPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/RemoveLinkTelemetryPatch.kt
Outdated
Show resolved
Hide resolved
...kotlin/app/revanced/patches/twitter/misc/links/fingerprints/AddTelemetryToLinkFingerprint.kt
Outdated
Show resolved
Hide resolved
.../kotlin/app/revanced/patches/twitter/misc/links/fingerprints/LinkBuilderMethodFingerprint.kt
Outdated
Show resolved
Hide resolved
…LinkSharingDomainPatch.kt Co-authored-by: oSumAtrIX <[email protected]>
…LinkTelemetryPatch.kt Co-authored-by: oSumAtrIX <[email protected]>
|
Is this PR still active? |
|
Hey @FrozenAlex! Thanks for this patch. It's gonna be a very useful feature to have because now we have to edit all the shared links manually. I really hope @oSumAtrIX is gonna accept it to the main base. |
|
All of the requested changes seem to be resolved, do I need to add handling of links directly here or should it be a separate pull request? I need some time on making them work well. Nvm, those are going into a separate pull request. |
|
My build had some outdated types, updated them |
|
Should fix issue ReVanced/revanced-patches-template#764 |
oSumAtrIX
reviewed
Dec 1, 2023
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
requested changes
Dec 1, 2023
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
JeroenMathon
reviewed
Dec 2, 2023
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
oSumAtrIX
reviewed
Dec 4, 2023
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Dec 4, 2023
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Dec 4, 2023
src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
requested changes
Dec 4, 2023
|
Hey, just letting you know that we have renamed repositories. Please close this PR and re-open it here. PS: No additional changes are needed to your remotes. |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch replaces x.com and twitter.com in share by fxtwitter.com and optionally other mirrors.
Since twitter does not have a settings GUI yet, I use patch options to configure the patch.
Update: added a patch to remove tracking from links