Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate codebase to React 16-compatible lifecycles #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate codebase to React 16-compatible lifecycles #30

wants to merge 1 commit into from

Conversation

Rendez
Copy link

@Rendez Rendez commented May 31, 2018 •
edited
Loading

  1. Uses Lifecycles from 16.3 to guarantee future compatibility.
  2. History objects are only created if there's an existing DOM in the runtime: this gives implementors the chance to skip initializing history on runtimes without DOM polyfilling/support, e.g.: a running instance Node.js without js-dom.

Depends on #28

Migrate codebase to React 16-compatible lifecycles
d39c743 
In addition history objects are only created if there's an existing DOM in the runtime.

This gives implementors the chance to skip initializing history on runtimes without DOM
polyfilling/support, e.g.: a running instance Node.js without js-dom.
@gitgrimbo
Copy link

Hi, will this be merged?

@gitgrimbo gitgrimbo mentioned this pull request Aug 13, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rendez @gitgrimbo