Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the environment to reflect the addition of RMS into RMG #475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update the environment to reflect the addition of RMS into RMG #475

wants to merge 1 commit into from
+4 −0

Conversation

xiaoruiDong
Copy link
Contributor

Recently RMG added new dependencies related to RMS. Add those dependencies according to the environment file in RMG.

@xiaoruiDong xiaoruiDong self-assigned this Oct 8, 2021
@xiaoruiDong xiaoruiDong requested a review from alongd October 8, 2021 05:31
@xiaoruiDong
Copy link
Contributor Author

Failure in the unit tests is either due to zmat related functions (not touched in this PR) or due to numerical errors (which may be due to a change in package version of numpy, etc. due to the addition of a new package.) I believe it is fairly safe to merge this PR.

@alongd
Copy link
Member

alongd commented Oct 9, 2021

Please use compare_zmats for the failing tests and assertAlmostEqual where relevant.
Feel free to use compare_zmats even for passing tests that compare zmats if you find them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongd alongd Awaiting requested review from alongd

At least 1 approving review is required to merge this pull request.

Assignees

@xiaoruiDong xiaoruiDong

Labels
Type: Risk of Error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoruiDong @alongd