Added 'is not None' to if conditions #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #626 +/- ##
=======================================
Coverage 73.02% 73.02%
=======================================
Files 99 99
Lines 26179 26179
Branches 5482 5482
=======================================
+ Hits 19116 19118 +2
+ Misses 5700 5699 -1
+ Partials 1363 1362 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alongd
reviewed
Mar 29, 2023
|
I added one comment, please rebase and squash |
calvinp0
force-pushed
the
623-receiving-keyerror-0-when-attempting-arcrestart
branch
2 times, most recently
from
6a6c76c to
df49754
Compare
Adjusted some if conditions to check for isinstance(variable, type)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original issue, when a
self.variable =0, then theif self.variable:was not met in theas_dict()function found in the script:ARC/arc/job/adapter.py
Line 824 in ba4f5b9