Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use output consistently throughout main #760

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Use output consistently throughout main #760

merged 2 commits into from
Aug 11, 2024

Conversation

alongd
Copy link
Member

@alongd alongd commented Aug 11, 2024

Solves a KeyError issue with an empty output dict in main, especially after ARC cannot find a TS for a reaction.

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.74%. Comparing base (df19d8f) to head (8cb54d1).

Files Patch % Lines
arc/main.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #760   +/-   ##
=======================================
  Coverage   73.73%   73.74%           
=======================================
  Files          99       99           
  Lines       27472    27473    +1     
  Branches     5781     5781           
=======================================
+ Hits        20257    20259    +2     
  Misses       5766     5766           
+ Partials     1449     1448    -1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@calvinp0 calvinp0 merged commit a3f79be into main Aug 11, 2024
7 of 8 checks passed
@calvinp0 calvinp0 deleted the output branch August 11, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants