Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydrolysis families and tests #770

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

tests for new hydrolysis families

3174e05
Select commit
Loading
Failed to load commit list.
Open

Hydrolysis families and tests #770

tests for new hydrolysis families
3174e05
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Nov 13, 2024 in 8s

30 new alerts including 26 errors

New alerts in code changed by this pull request

  • 26 errors
  • 4 notes

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 12 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'assign_labels_to_products' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of assign_labels_to_products occurs after the cyclic
import
of arc.mapping.driver.
'assign_labels_to_products' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of assign_labels_to_products occurs after the cyclic import of arc.mapping.driver.
'assign_labels_to_products' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of assign_labels_to_products occurs after the cyclic import of arc.mapping.driver.
'assign_labels_to_products' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of assign_labels_to_products occurs after the cyclic import of arc.mapping.driver.
'assign_labels_to_products' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of assign_labels_to_products occurs after the cyclic import of arc.mapping.driver.
'assign_labels_to_products' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of assign_labels_to_products occurs after the cyclic import of arc.mapping.driver.

Check failure on line 13 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'are_adj_elements_in_agreement' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of are_adj_elements_in_agreement occurs after the cyclic
import
of arc.mapping.driver.
'are_adj_elements_in_agreement' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of are_adj_elements_in_agreement occurs after the cyclic import of arc.mapping.driver.
'are_adj_elements_in_agreement' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of are_adj_elements_in_agreement occurs after the cyclic import of arc.mapping.driver.
'are_adj_elements_in_agreement' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of are_adj_elements_in_agreement occurs after the cyclic import of arc.mapping.driver.
'are_adj_elements_in_agreement' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of are_adj_elements_in_agreement occurs after the cyclic import of arc.mapping.driver.
'are_adj_elements_in_agreement' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of are_adj_elements_in_agreement occurs after the cyclic import of arc.mapping.driver.

Check failure on line 14 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'create_qc_mol' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of create_qc_mol occurs after the cyclic
import
of arc.mapping.driver.

Check failure on line 15 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'flip_map' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of flip_map occurs after the cyclic
import
of arc.mapping.driver.

Check failure on line 16 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'fingerprint' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of fingerprint occurs after the cyclic
import
of arc.mapping.driver.

Check failure on line 17 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'get_atom_indices_of_labeled_atoms_in_a_reaction' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of get_atom_indices_of_labeled_atoms_in_a_reaction occurs after the cyclic
import
of arc.mapping.driver.

Check failure on line 18 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'glue_maps' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of glue_maps occurs after the cyclic
import
of arc.mapping.driver.
'glue_maps' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of glue_maps occurs after the cyclic import of arc.mapping.driver.
'glue_maps' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of glue_maps occurs after the cyclic import of arc.mapping.driver.
'glue_maps' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of glue_maps occurs after the cyclic import of arc.mapping.driver.
'glue_maps' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of glue_maps occurs after the cyclic import of arc.mapping.driver.
'glue_maps' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of glue_maps occurs after the cyclic import of arc.mapping.driver.

Check failure on line 19 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'label_species_atoms' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of label_species_atoms occurs after the cyclic
import
of arc.mapping.driver.
'label_species_atoms' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of label_species_atoms occurs after the cyclic import of arc.mapping.driver.
'label_species_atoms' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of label_species_atoms occurs after the cyclic import of arc.mapping.driver.
'label_species_atoms' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of label_species_atoms occurs after the cyclic import of arc.mapping.driver.
'label_species_atoms' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of label_species_atoms occurs after the cyclic import of arc.mapping.driver.
'label_species_atoms' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of label_species_atoms occurs after the cyclic import of arc.mapping.driver.

Check failure on line 20 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'make_bond_changes' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of make_bond_changes occurs after the cyclic
import
of arc.mapping.driver.
'make_bond_changes' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of make_bond_changes occurs after the cyclic import of arc.mapping.driver.
'make_bond_changes' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of make_bond_changes occurs after the cyclic import of arc.mapping.driver.
'make_bond_changes' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of make_bond_changes occurs after the cyclic import of arc.mapping.driver.
'make_bond_changes' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of make_bond_changes occurs after the cyclic import of arc.mapping.driver.
'make_bond_changes' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of make_bond_changes occurs after the cyclic import of arc.mapping.driver.

Check failure on line 21 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'map_pairs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_pairs occurs after the cyclic
import
of arc.mapping.driver.
'map_pairs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_pairs occurs after the cyclic import of arc.mapping.driver.
'map_pairs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_pairs occurs after the cyclic import of arc.mapping.driver.
'map_pairs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_pairs occurs after the cyclic import of arc.mapping.driver.
'map_pairs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_pairs occurs after the cyclic import of arc.mapping.driver.
'map_pairs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_pairs occurs after the cyclic import of arc.mapping.driver.

Check failure on line 22 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'iterative_dfs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of iterative_dfs occurs after the cyclic
import
of arc.mapping.driver.
'iterative_dfs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of iterative_dfs occurs after the cyclic import of arc.mapping.driver.
'iterative_dfs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of iterative_dfs occurs after the cyclic import of arc.mapping.driver.
'iterative_dfs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of iterative_dfs occurs after the cyclic import of arc.mapping.driver.
'iterative_dfs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of iterative_dfs occurs after the cyclic import of arc.mapping.driver.
'iterative_dfs' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of iterative_dfs occurs after the cyclic import of arc.mapping.driver.

Check failure on line 22 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'map_two_species' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_two_species occurs after the cyclic
import
of arc.mapping.driver.
'map_two_species' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_two_species occurs after the cyclic import of arc.mapping.driver.
'map_two_species' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_two_species occurs after the cyclic import of arc.mapping.driver.
'map_two_species' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_two_species occurs after the cyclic import of arc.mapping.driver.
'map_two_species' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_two_species occurs after the cyclic import of arc.mapping.driver.
'map_two_species' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of map_two_species occurs after the cyclic import of arc.mapping.driver.

Check failure on line 23 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'pairing_reactants_and_products_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of pairing_reactants_and_products_for_mapping occurs after the cyclic
import
of arc.mapping.driver.
'pairing_reactants_and_products_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of pairing_reactants_and_products_for_mapping occurs after the cyclic import of arc.mapping.driver.
'pairing_reactants_and_products_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of pairing_reactants_and_products_for_mapping occurs after the cyclic import of arc.mapping.driver.
'pairing_reactants_and_products_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of pairing_reactants_and_products_for_mapping occurs after the cyclic import of arc.mapping.driver.
'pairing_reactants_and_products_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of pairing_reactants_and_products_for_mapping occurs after the cyclic import of arc.mapping.driver.
'pairing_reactants_and_products_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of pairing_reactants_and_products_for_mapping occurs after the cyclic import of arc.mapping.driver.

Check failure on line 24 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'copy_species_list_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of copy_species_list_for_mapping occurs after the cyclic
import
of arc.mapping.driver.
'copy_species_list_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of copy_species_list_for_mapping occurs after the cyclic import of arc.mapping.driver.
'copy_species_list_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of copy_species_list_for_mapping occurs after the cyclic import of arc.mapping.driver.
'copy_species_list_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of copy_species_list_for_mapping occurs after the cyclic import of arc.mapping.driver.
'copy_species_list_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of copy_species_list_for_mapping occurs after the cyclic import of arc.mapping.driver.
'copy_species_list_for_mapping' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of copy_species_list_for_mapping occurs after the cyclic import of arc.mapping.driver.

Check failure on line 25 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'find_all_bdes' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of find_all_bdes occurs after the cyclic
import
of arc.mapping.driver.

Check failure on line 26 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'cut_species_based_on_atom_indices' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of cut_species_based_on_atom_indices occurs after the cyclic
import
of arc.mapping.driver.

Check failure on line 27 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'update_xyz' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of update_xyz occurs after the cyclic
import
of arc.mapping.driver.

Check failure on line 28 in arc/mapping/driver.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'RESERVED_FINGERPRINT_KEYS' may not be defined if module
arc.mapping.engine
is imported before module
arc.mapping.driver
, as the
definition
of RESERVED_FINGERPRINT_KEYS occurs after the cyclic
import
of arc.mapping.driver.

Check failure on line 22 in arc/mapping/engine.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'ReactionFamily' may not be defined if module
arc.reaction.family
is imported before module
arc.mapping.engine
, as the
definition
of ReactionFamily occurs after the cyclic
import
of arc.mapping.engine.

Check failure on line 22 in arc/mapping/engine.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'get_reaction_family_products' may not be defined if module
arc.reaction.family
is imported before module
arc.mapping.engine
, as the
definition
of get_reaction_family_products occurs after the cyclic
import
of arc.mapping.engine.

Check notice on line 1394 in arc/mapping/engine.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused local variable Note

Variable product_pairs is not used.

Check failure on line 529 in arc/mapping/engine_test.py

See this annotation in the file changed.

Code scanning / CodeQL

Wrong number of arguments in a call Error

Call to
function assign_labels_to_products
with too few arguments; should be no fewer than 2.

Check failure on line 646 in arc/mapping/engine_test.py

See this annotation in the file changed.

Code scanning / CodeQL

Wrong number of arguments in a call Error

Call to
function assign_labels_to_products
with too few arguments; should be no fewer than 2.

Check notice on line 859 in arc/mapping/engine_test.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check failure on line 1333 in arc/mapping/engine_test.py

See this annotation in the file changed.

Code scanning / CodeQL

Wrong number of arguments in a call Error

Call to
function assign_labels_to_products
with too few arguments; should be no fewer than 2.