-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python 3.9] Overhaul RMG-RMS Python-Julia dependencies (juliaup
and pythoncall
), Add Tests for Arkane Network Algorithms
#2687
Draft
JacksonBurns
wants to merge
68
commits into
main
Choose a base branch
from
feat/py39
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jun 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 798a1b0 - Browse repository at this point
Copy the full SHA 798a1b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b4f136 - Browse repository at this point
Copy the full SHA 8b4f136View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3796da - Browse repository at this point
Copy the full SHA b3796daView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4c539e - Browse repository at this point
Copy the full SHA d4c539eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8faefb - Browse repository at this point
Copy the full SHA e8faefbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f52d0d7 - Browse repository at this point
Copy the full SHA f52d0d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1f2017 - Browse repository at this point
Copy the full SHA c1f2017View commit details -
Configuration menu - View commit details
-
Copy full SHA for a11a96d - Browse repository at this point
Copy the full SHA a11a96dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05d1772 - Browse repository at this point
Copy the full SHA 05d1772View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f5612c - Browse repository at this point
Copy the full SHA 6f5612cView commit details -
Configuration menu - View commit details
-
Copy full SHA for be3e424 - Browse repository at this point
Copy the full SHA be3e424View commit details -
Configuration menu - View commit details
-
Copy full SHA for a812cab - Browse repository at this point
Copy the full SHA a812cabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a165ee - Browse repository at this point
Copy the full SHA 0a165eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf7017b - Browse repository at this point
Copy the full SHA bf7017bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b312ca1 - Browse repository at this point
Copy the full SHA b312ca1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4fc809 - Browse repository at this point
Copy the full SHA c4fc809View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ce04fd - Browse repository at this point
Copy the full SHA 3ce04fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17f397b - Browse repository at this point
Copy the full SHA 17f397bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f65d07d - Browse repository at this point
Copy the full SHA f65d07dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d52efbf - Browse repository at this point
Copy the full SHA d52efbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7c0632 - Browse repository at this point
Copy the full SHA c7c0632View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e770fb - Browse repository at this point
Copy the full SHA 7e770fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29e6c43 - Browse repository at this point
Copy the full SHA 29e6c43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a473df - Browse repository at this point
Copy the full SHA 7a473dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09c45bf - Browse repository at this point
Copy the full SHA 09c45bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd219c2 - Browse repository at this point
Copy the full SHA cd219c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff81064 - Browse repository at this point
Copy the full SHA ff81064View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11f0923 - Browse repository at this point
Copy the full SHA 11f0923View commit details -
Configuration menu - View commit details
-
Copy full SHA for 332d8c0 - Browse repository at this point
Copy the full SHA 332d8c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0369843 - Browse repository at this point
Copy the full SHA 0369843View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5723de3 - Browse repository at this point
Copy the full SHA 5723de3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 117926b - Browse repository at this point
Copy the full SHA 117926bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55c462f - Browse repository at this point
Copy the full SHA 55c462fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4d0a06 - Browse repository at this point
Copy the full SHA d4d0a06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45fda81 - Browse repository at this point
Copy the full SHA 45fda81View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5fbaa5 - Browse repository at this point
Copy the full SHA c5fbaa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4167d4c - Browse repository at this point
Copy the full SHA 4167d4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a81c71 - Browse repository at this point
Copy the full SHA 2a81c71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d4005a - Browse repository at this point
Copy the full SHA 1d4005aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cae6444 - Browse repository at this point
Copy the full SHA cae6444View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dabe3b - Browse repository at this point
Copy the full SHA 5dabe3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6efb3f - Browse repository at this point
Copy the full SHA a6efb3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 419adb5 - Browse repository at this point
Copy the full SHA 419adb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b46fff - Browse repository at this point
Copy the full SHA 3b46fffView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5b4ba0 - Browse repository at this point
Copy the full SHA b5b4ba0View commit details -
Co-authored-by: Jackson Burns <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 65575ca - Browse repository at this point
Copy the full SHA 65575caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e90ea0 - Browse repository at this point
Copy the full SHA 0e90ea0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19ae82b - Browse repository at this point
Copy the full SHA 19ae82bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d593a9 - Browse repository at this point
Copy the full SHA 0d593a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac7ef7d - Browse repository at this point
Copy the full SHA ac7ef7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fb30a1 - Browse repository at this point
Copy the full SHA 5fb30a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7130186 - Browse repository at this point
Copy the full SHA 7130186View commit details -
Configuration menu - View commit details
-
Copy full SHA for 078b93f - Browse repository at this point
Copy the full SHA 078b93fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54a1d8c - Browse repository at this point
Copy the full SHA 54a1d8cView commit details
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 72d23a0 - Browse repository at this point
Copy the full SHA 72d23a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3943c63 - Browse repository at this point
Copy the full SHA 3943c63View commit details -
fix cython compilation errors (0.23 -> 3.n), SEE EXTENDED!!
here are all the solutions that were implemented: - in a couple places we were implicitly casting a double to a numpy float, now need to explicitly grad the _real_ part of the double - Cython does not allow nested function declaration inside cpdef functions, move all of these outside of their parent functions or redefine them to be purely functional where practical - similar to the above, lambda function are no longer allowed - get the same treatment. what's different here is that usually we are using lambda in sorting calls, so we can replace these with operator.itemgetter or attrgetter, where relevant. this also involves re-writing a couple reduce calls, which also used lambda - modern cython does not allow re-declaring existing Cython variables (in previous versions this was a warning I think), so I just remove these where needed. (btw Cython is super cool, actually points out both of the declaration so that you can delete one) i made these fixes while listening to The Metal by Tenacious D, Talk Too Much by Renee Rapp, BEST INTEREST by Tyler, The Creator (love the bass line), mos thoser by food house, and Doritos & Fritos by 100 Gecs
Configuration menu - View commit details
-
Copy full SHA for a8ef015 - Browse repository at this point
Copy the full SHA a8ef015View commit details -
add newly defined functions to
pxd
filesas requested in: #2687 (comment)
Configuration menu - View commit details
-
Copy full SHA for 0aabfe8 - Browse repository at this point
Copy the full SHA 0aabfe8View commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ff46749 - Browse repository at this point
Copy the full SHA ff46749View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4b7db1 - Browse repository at this point
Copy the full SHA c4b7db1View commit details -
Configuration menu - View commit details
-
Copy full SHA for edd4ade - Browse repository at this point
Copy the full SHA edd4adeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 582d1ec - Browse repository at this point
Copy the full SHA 582d1ecView commit details -
DROP ME comment out failing lpsolve test for now
want to see if the problem comes up again elsewhere
Configuration menu - View commit details
-
Copy full SHA for b3a1365 - Browse repository at this point
Copy the full SHA b3a1365View commit details
Commits on Jul 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f45f7bd - Browse repository at this point
Copy the full SHA f45f7bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d3a765 - Browse repository at this point
Copy the full SHA 7d3a765View commit details
Commits on Jul 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bff1865 - Browse repository at this point
Copy the full SHA bff1865View commit details -
passthrough args to same_object
for some reason `functools.partial` is allowed, but not `lambda`
Configuration menu - View commit details
-
Copy full SHA for 0f87f76 - Browse repository at this point
Copy the full SHA 0f87f76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b2296d - Browse repository at this point
Copy the full SHA 7b2296dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.