Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and improve to_cantera methods for conversion to in-memory Cantera objects #2700

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add and improve to_cantera methods for conversion to in-memory Cantera objects #2700

wants to merge 8 commits into from
+343 −61

Commits on Nov 23, 2024

  1. Tweaking Chemkin species list parser for readability. 

    This took me a while to figure out  what was happening.
So I changed variable name, removed a redundant if block,
and added a couple of comments.
    @rwest
    rwest committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    2c9a160 View commit details
    Browse the repository at this point in the history

  2. Cleaning up chemkinTest methods for multidentate adsorbate writing. 

    It was fragile, depending on the precise ordering of lines
in the test file.
    @rwest
    rwest committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    10a29f3 View commit details
    Browse the repository at this point in the history

  3. Cleaning up and extending a chemkin test mechanism. 

    To enable proper conversion in Cantera (for a future test)
we need some gas phase parts to the chemkin mechanism.
I added two extra types of surface reaction, an adsorption
sticking coefficient, and an associative desorption.
I also tidied up the species names and formatting.
    @rwest
    rwest committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    6733e6a View commit details
    Browse the repository at this point in the history

  4. Updating methods that create in-memory Cantera objects of things. 

    to_cantera for Reaction and Species and some surface kinetics types

squashed commit from Richard:
Should be able to use the to_cantera_kinetics methods.
Not sure about all these nested elifs. I think some are confused.

Co-authored-by:  Nora Khalil <[email protected]>
Co-authored-by:  Richard West <[email protected]>
    @Nora-Khalil @rwest
    Nora-Khalil and rwest committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    689134f View commit details
    Browse the repository at this point in the history

  5. Fixing docstrings in surface kinetics.

    @rwest
    rwest committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    f8a00d9 View commit details
    Browse the repository at this point in the history

  6. Added to_cantera_kinetics for SurfaceArrhenius and StickingCoefficient 

    Nick add cm^5/(mol^2*s) dimensionality

Co-authored-by:  Sevy Harris <[email protected]>
Co-authored-by:  Nicholas Tietje <[email protected]>
    @sevyharris @ntietje1 @rwest
    2 people authored and rwest committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b26129c View commit details
    Browse the repository at this point in the history

  7. Adding to_cantera_kinetics for ArrheniusBM class. 

    Cantera now has a BlowersMasel kinetics class.

This requires Cantera > 2.6
As described in
https://cantera.org/dev/python/kinetics.html#cantera.BlowersMaselRate
the API may change suddenly on some versions.
    @rwest
    rwest committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    15ce6d5 View commit details
    Browse the repository at this point in the history

  8. Testing conversion to Cantera for adsorbed species and reactions. 

    This is in the canteramodelTest. We load a gas/surface mechanism 
saved in chemkin format (updated in prior commit) into both RMG
and into Cantera. We then convert the RMG objects into Cantera objects
and then compare them all - species and reactions.
This mirrors the way the gas phase parts were tested.
Hopefully increases test coverage of the new to_cantera_kinetics methods.
    @rwest
    rwest committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    fe9e0b1 View commit details
    Browse the repository at this point in the history