Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed frequencies of the Nitro group (statmech groups.py) #108

Merged
merged 1 commit into from
Jul 6, 2016

Conversation

alongd
Copy link
Member

@alongd alongd commented Jun 17, 2016

In statmech groups.py I changed the frequencies of the Nitro (R-NO2) group. This group was originally assigned 6 frequencies, while it is only allowed a maximum of 5 (see https://dspace.mit.edu/handle/1721.1/59876). The weakest frequency range of 1545-1555 1/cm was hence removed.

@rwest
Copy link
Member

rwest commented Jun 17, 2016

I nominate @cfgold to review this 😉
No, wait a sec, @cfgoldsmith! What are you doing with two accounts?

@alongd
Copy link
Member Author

alongd commented Jun 17, 2016

;)
And, for the record, while the frequencies of CH3NO2, for example, did change as a result of this commit, there was no observable effect on the PDep rate for CH3NO2 = CH3 + NO2.

…oup was originally assigned 6 frequencies, while it is only allowed a maximum of 5 (see https://dspace.mit.edu/handle/1721.1/59876). The weakest frequency range of 1545-1555 1/cm was hence removed.
@connie connie merged commit f923ba3 into ReactionMechanismGenerator:master Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants