Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flux diagrams #141

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Added flux diagrams #141

merged 8 commits into from
Nov 9, 2023

Conversation

alongd
Copy link
Member

@alongd alongd commented Oct 24, 2023

Added the ability to automatically generate flux diagrams for Cantera models.

Still need to add (here or in future PRs):

  • Use this in T3 (at each iteration?)
  • Add burner and shocktube reactor
  • Allow to draw molecules instead of lables

t3/utils/flux.py Fixed Show fixed Hide fixed
@alongd alongd force-pushed the flux_d branch 5 times, most recently from 0c2ae8e to 6c213c8 Compare October 30, 2023 19:44
@alongd alongd force-pushed the flux_d branch 2 times, most recently from f92ac4b to f650936 Compare November 2, 2023 19:59
@codecov-commenter
Copy link

Codecov Report

Merging #141 (d60fa59) into main (2de3b76) will increase coverage by 1.69%.
Report is 65 commits behind head on main.
The diff coverage is 83.77%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   73.46%   75.15%   +1.69%     
==========================================
  Files          22       24       +2     
  Lines        2891     3293     +402     
  Branches      762      842      +80     
==========================================
+ Hits         2124     2475     +351     
- Misses        552      593      +41     
- Partials      215      225      +10     
Flag Coverage Δ
unittests 75.15% <83.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
t3/common.py 89.77% <100.00%> (+5.86%) ⬆️
t3/logger.py 60.00% <ø> (-1.09%) ⬇️
t3/settings/t3_settings.py 100.00% <ø> (ø)
t3/settings/t3_submit.py 100.00% <ø> (ø)
t3/runners/rmg_runner.py 34.37% <0.00%> (ø)
t3/imports.py 30.00% <40.00%> (ø)
t3/simulate/rmg_constantTP.py 58.41% <0.00%> (ø)
t3/utils/fix_cantera.py 90.66% <90.66%> (ø)
t3/utils/flux.py 84.35% <84.35%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@calvinp0 calvinp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@calvinp0 calvinp0 merged commit cf69799 into main Nov 9, 2023
4 checks passed
@calvinp0 calvinp0 deleted the flux_d branch November 9, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants