fix #434: determine threads/cores via extra package Hwloc, if CpuId fails #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 190 190
Lines 5493 5493
=======================================
Hits 3986 3986
Misses 1507 1507 ☔ View full report in Codecov by Sentry. |
bvdmitri
reviewed
Dec 18, 2024
test/runtests.jl
Outdated
| @@ -1,8 +1,10 @@ | |||
| using Aqua, CpuId, ReTestItems, ReactiveMP | |||
| using Aqua, CpuId, ReTestItems, ReactiveMP, Hwloc | |||
There was a problem hiding this comment.
Do we need CpuId then? Can we just use Hwloc in all situations?
There was a problem hiding this comment.
I think the only argument for CpuId is that it is very fast since you only have to run one instruction cpuid.
We only need it once so the theoretical performance increase is non-existant or minimal at best 😄.
Should I just remove the CpuId requirement 👍 👎 ?
|
Removed dependency for |
bvdmitri
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #434 .
Let me know if I need to add a test for this? It works now locally and Hwloc only triggers if CpuId fails (which is only in the case of ARM machines).
As soon as this works, I'll update the runtests.jl in the other packages accordingly.