Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance functional dependencies customization in ReactiveMP #437

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

bvdmitri
Copy link
Member

@bvdmitri bvdmitri commented Jan 3, 2025

This PR fixes #436

This pull request include updates to the ReactiveMP library documentation and functionality, focusing on the customization of functional dependencies for nodes. The changes enhance the documentation, add new features for runtime customization, and includes tests to ensure the new functionality works as intended.

Users now can specify

function ReactiveMP.collect_functional_dependencies(::Type{CustomNode}, options::FactorNodeActivationOptions)
    # custom behaviour
end

to set functional dependencies in runtime. options has an access to various settings, including metadata as requested in the original issue.

@bvdmitri bvdmitri requested a review from wouterwln January 3, 2025 10:51
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.23%. Comparing base (9368139) to head (a3a943d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/nodes/nodes.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   72.56%   73.23%   +0.66%     
==========================================
  Files         190      190              
  Lines        5493     5495       +2     
==========================================
+ Hits         3986     4024      +38     
+ Misses       1507     1471      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvdmitri bvdmitri merged commit 11e816c into main Jan 3, 2025
5 of 6 checks passed
@bvdmitri bvdmitri deleted the fix-436 branch January 3, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow meta object to change default functional dependencies
2 participants