Fix SDK path issues with ubuntu-24.04 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychescale9
changed the title
mikehardy
reviewed
Oct 11, 2024
lib/sdk-installer.js
Outdated
Comment on lines
56
to
58
| if (fs.existsSync(cmdlineToolsPath)) { | ||
| yield io.rmRF(cmdlineToolsPath); | ||
| } |
There was a problem hiding this comment.
This may be a simpler / better approach than #411 - but with 411 there is the possibility we skip the install if the runner image ever has the updated version. That may have value
However I see this nice io.rmRF call and that's better than I do in 411 - I was shelling out to rm things
mikehardy
reviewed
Oct 11, 2024
src/sdk-installer.ts
Outdated
| // await exec.exec(`sh -c \\"sudo chown $USER:$USER ${process.env.ANDROID_HOME}/platform-tools -R`); | ||
| // await exec.exec(`sh -c \\"sudo chown $USER:$USER ${process.env.ANDROID_HOME}/cmdline-tools/latest -R`); | ||
| // await exec.exec(`sh -c \\"sudo chown $USER:$USER ${process.env.ANDROID_HOME}/build-tools/${BUILD_TOOLS_VERSION} -R`); | ||
| // } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ychescale9
commented
Oct 11, 2024
Comment on lines
-22
to
-26
| if (!isOnMac) { | ||
| await exec.exec(`sh -c \\"sudo chown $USER:$USER ${process.env.ANDROID_HOME}/platform-tools -R`); | ||
| await exec.exec(`sh -c \\"sudo chown $USER:$USER ${process.env.ANDROID_HOME}/cmdline-tools/latest -R`); | ||
| await exec.exec(`sh -c \\"sudo chown $USER:$USER ${process.env.ANDROID_HOME}/build-tools/${BUILD_TOOLS_VERSION} -R`); | ||
| } |
There was a problem hiding this comment.
Originally we needed to change the owner to accept preview SDK license: 49a3d04#diff-b14a072bf3d3c4d7027a549c57f0c1880f60206c24fc202ce4471ab9c0a5881cR23-R28
But this seems no longer required.
This was referenced Oct 11, 2024
Closed
ychescale9
added a commit
that referenced
this pull request
Oct 12, 2024
* main: Prepare for release 2.33.0. Fix avd path on ubuntu-24.04 - attempt 2 (#415) Revert creating avd directory. (#414) Fix SDK path issues with ubuntu-24.04 (#409) SDK build tools 35.0.0, command-line tools 16.0. (#408) Avoid changing the owner of unnecessary files (#406) Update npm packages. (#401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #400