Replace ThemePreviews with @PreviewLightDark.

ReactiveCircus · Dec 1, 2023 · b4bf0c2 · b4bf0c2
1 parent 785be05
commit b4bf0c2
Show file tree

Hide file tree

Showing 12 changed files with 30 additions and 38 deletions.
diff --git a/.../main/java/io/github/reactivecircus/kstreamlined/android/common/ui/feed/KotlinBlogCard.kt b/.../main/java/io/github/reactivecircus/kstreamlined/android/common/ui/feed/KotlinBlogCard.kt
@@ -13,9 +13,9 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.layout.ContentScale
 import androidx.compose.ui.text.style.TextOverflow
+import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.dp
 import coil.compose.AsyncImage
-import io.github.reactivecircus.kstreamlined.android.designsystem.ThemePreviews
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.IconButton
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Surface
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Text
@@ -91,7 +91,7 @@ public fun KotlinBlogCard(
 private val ImageHeight = 200.dp
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewKotlinBlogCard_unsaved() {
     KSTheme {
         Surface {
@@ -113,7 +113,7 @@ private fun PreviewKotlinBlogCard_unsaved() {
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewKotlinBlogCard_saved() {
     KSTheme {
         Surface {

diff --git a/...ain/java/io/github/reactivecircus/kstreamlined/android/common/ui/feed/KotlinWeeklyCard.kt b/...ain/java/io/github/reactivecircus/kstreamlined/android/common/ui/feed/KotlinWeeklyCard.kt
@@ -13,8 +13,8 @@ import androidx.compose.ui.geometry.CornerRadius
 import androidx.compose.ui.graphics.Brush
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.text.style.TextOverflow
+import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.dp
-import io.github.reactivecircus.kstreamlined.android.designsystem.ThemePreviews
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.IconButton
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Surface
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Text
@@ -88,7 +88,7 @@ public fun KotlinWeeklyCard(
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewKotlinWeeklyCard_unsaved() {
     KSTheme {
         Surface {
@@ -109,7 +109,7 @@ private fun PreviewKotlinWeeklyCard_unsaved() {
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewKotlinWeeklyCard_saved() {
     KSTheme {
         Surface {

diff --git a/...in/java/io/github/reactivecircus/kstreamlined/android/common/ui/feed/KotlinYouTubeCard.kt b/...in/java/io/github/reactivecircus/kstreamlined/android/common/ui/feed/KotlinYouTubeCard.kt
@@ -21,9 +21,9 @@ import androidx.compose.ui.draw.clip
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.layout.ContentScale
 import androidx.compose.ui.text.style.TextOverflow
+import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.dp
 import coil.compose.AsyncImage
-import io.github.reactivecircus.kstreamlined.android.designsystem.ThemePreviews
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Icon
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.IconButton
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Surface
@@ -139,7 +139,7 @@ private fun PlayIconOverlay(
 private val ImageHeight = 200.dp
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewKotlinYouTubeCard_unsaved() {
     KSTheme {
         Surface {
@@ -162,7 +162,7 @@ private fun PreviewKotlinYouTubeCard_unsaved() {
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewKotlinYouTubeCard_saved() {
     KSTheme {
         Surface {

diff --git a/...in/java/io/github/reactivecircus/kstreamlined/android/common/ui/feed/TalkingKotlinCard.kt b/...in/java/io/github/reactivecircus/kstreamlined/android/common/ui/feed/TalkingKotlinCard.kt
@@ -13,9 +13,9 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.layout.ContentScale
 import androidx.compose.ui.text.style.TextOverflow
+import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.dp
 import coil.compose.AsyncImage
-import io.github.reactivecircus.kstreamlined.android.designsystem.ThemePreviews
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.IconButton
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Surface
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Text
@@ -89,7 +89,7 @@ public fun TalkingKotlinCard(
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewTalkingKotlinCard_unsaved() {
     KSTheme {
         Surface {
@@ -111,7 +111,7 @@ private fun PreviewTalkingKotlinCard_unsaved() {
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewTalkingKotlinCard_saved() {
     KSTheme {
         Surface {

diff --git a/...src/main/java/io/github/reactivecircus/kstreamlined/android/designsystem/ThemePreviews.kt b/...src/main/java/io/github/reactivecircus/kstreamlined/android/designsystem/ThemePreviews.kt
diff --git a/...rc/main/java/io/github/reactivecircus/kstreamlined/android/designsystem/component/Chip.kt b/...rc/main/java/io/github/reactivecircus/kstreamlined/android/designsystem/component/Chip.kt
@@ -9,8 +9,8 @@ import androidx.compose.runtime.Composable
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
+import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.dp
-import io.github.reactivecircus.kstreamlined.android.designsystem.ThemePreviews
 import io.github.reactivecircus.kstreamlined.android.designsystem.foundation.KSTheme
 import io.github.reactivecircus.kstreamlined.android.designsystem.foundation.icon.KSIcons
 
@@ -44,7 +44,7 @@ public fun Chip(
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewChip() {
     KSTheme {
         Surface {

diff --git a/...main/java/io/github/reactivecircus/kstreamlined/android/designsystem/component/Divider.kt b/...main/java/io/github/reactivecircus/kstreamlined/android/designsystem/component/Divider.kt
@@ -11,9 +11,9 @@ import androidx.compose.runtime.NonRestartableComposable
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
+import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.Dp
 import androidx.compose.ui.unit.dp
-import io.github.reactivecircus.kstreamlined.android.designsystem.ThemePreviews
 import io.github.reactivecircus.kstreamlined.android.designsystem.foundation.KSTheme
 import androidx.compose.material3.HorizontalDivider as MaterialHorizontalDivider
 import androidx.compose.material3.VerticalDivider as MaterialVerticalDivider
@@ -47,7 +47,7 @@ public fun VerticalDivider(
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewHorizontalDivider() {
     KSTheme {
         Surface {
@@ -67,7 +67,7 @@ private fun PreviewHorizontalDivider() {
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewVerticalDivider() {
     KSTheme {
         Surface {

diff --git a/...n/java/io/github/reactivecircus/kstreamlined/android/designsystem/component/IconButton.kt b/...n/java/io/github/reactivecircus/kstreamlined/android/designsystem/component/IconButton.kt
@@ -24,9 +24,9 @@ import androidx.compose.ui.graphics.vector.ImageVector
 import androidx.compose.ui.semantics.Role
 import androidx.compose.ui.semantics.role
 import androidx.compose.ui.semantics.semantics
+import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.Dp
 import androidx.compose.ui.unit.dp
-import io.github.reactivecircus.kstreamlined.android.designsystem.ThemePreviews
 import io.github.reactivecircus.kstreamlined.android.designsystem.foundation.KSTheme
 import io.github.reactivecircus.kstreamlined.android.designsystem.foundation.color.LocalContentColor
 import io.github.reactivecircus.kstreamlined.android.designsystem.foundation.icon.BookmarkAdd
@@ -155,7 +155,7 @@ private val LargeIconSize = 32.dp
 private val LargeContainerSize = 48.dp
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewIconButton() {
     KSTheme {
         Surface {
@@ -170,7 +170,7 @@ private fun PreviewIconButton() {
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewLargeIconButton() {
     KSTheme {
         Surface {
@@ -185,7 +185,7 @@ private fun PreviewLargeIconButton() {
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewFilledIconButton() {
     KSTheme {
         Surface {

diff --git a/...in/java/io/github/reactivecircus/kstreamlined/android/designsystem/component/TopNavBar.kt b/...in/java/io/github/reactivecircus/kstreamlined/android/designsystem/component/TopNavBar.kt
@@ -21,10 +21,10 @@ import androidx.compose.ui.graphics.Shader
 import androidx.compose.ui.graphics.ShaderBrush
 import androidx.compose.ui.text.font.FontWeight
 import androidx.compose.ui.text.style.TextOverflow
+import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.Dp
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
-import io.github.reactivecircus.kstreamlined.android.designsystem.ThemePreviews
 import io.github.reactivecircus.kstreamlined.android.designsystem.foundation.KSTheme
 import io.github.reactivecircus.kstreamlined.android.designsystem.foundation.icon.KSIcons
 
@@ -118,7 +118,7 @@ private fun GradientTitle(
 private const val GradientHorizontalScale = 1.3f
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewTopNavBar() {
     KSTheme {
         Surface {
@@ -137,7 +137,7 @@ private fun PreviewTopNavBar() {
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewTopNavBar_withBottomRow() {
     KSTheme {
         Surface {
@@ -171,7 +171,7 @@ private fun PreviewTopNavBar_withBottomRow() {
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewTopNavBar_withNavigationIcon() {
     KSTheme {
         Surface {

diff --git a/...va/io/github/reactivecircus/kstreamlined/android/feature/home/component/FeedFilterChip.kt b/...va/io/github/reactivecircus/kstreamlined/android/feature/home/component/FeedFilterChip.kt
@@ -5,9 +5,9 @@ import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.font.FontWeight
+import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
-import io.github.reactivecircus.kstreamlined.android.designsystem.ThemePreviews
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Chip
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Icon
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Surface
@@ -39,7 +39,7 @@ internal fun FeedFilterChip(
 }
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewFeedFilterChip() {
     KSTheme {
         Surface {

diff --git a/...n/java/io/github/reactivecircus/kstreamlined/android/feature/home/component/SyncButton.kt b/...n/java/io/github/reactivecircus/kstreamlined/android/feature/home/component/SyncButton.kt
@@ -16,9 +16,9 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.rotate
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.font.FontWeight
+import androidx.compose.ui.tooling.preview.PreviewLightDark
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
-import io.github.reactivecircus.kstreamlined.android.designsystem.ThemePreviews
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Chip
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Icon
 import io.github.reactivecircus.kstreamlined.android.designsystem.component.Surface
@@ -84,7 +84,7 @@ internal fun SyncButton(
 private const val AnimationDurationMillis = 1000
 
 @Composable
-@ThemePreviews
+@PreviewLightDark
 private fun PreviewSyncButton() {
     KSTheme {
         Surface {

diff --git a/detekt.yml b/detekt.yml
@@ -29,4 +29,4 @@ style:
   UnusedPrivateMember:
     ignoreAnnotated:
       - Preview
-      - ThemePreviews
+      - PreviewLightDark