Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken productName values #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix broken productName values #104

wants to merge 1 commit into from

Conversation

liscio
Copy link

@liscio liscio commented May 31, 2017

This (should be) a very minimally invasive PR.

The background:

In general, Xcode appears to behave very badly when using workspaces and its "Find Implicit Dependencies" feature in the scheme editor. Many folks throw up their hands and resort to manual dependency specifications.

Well I think that its terrible behavior can be attributed to a bug in Xcode that causes it to not update the productName value in the .pbxproj file when a target is renamed. This happens very commonly when creating a framework project, then duplicating the framework targets with suffixes for other platforms.

For some folks, this patch may improve their build experience in Xcode quite a bit—especially for follks like me with very large workspaces that involve a lot of subprojects.

Sorry it took so long to write this one up after making the branch—I hadn't verified that the fix actually worked until I hit the issue again today, and fixing the productName value resolved my dependency issue. I'll try and cook up a Radar for this now that I know the steps.

@erichoracek
Copy link
Contributor

Will wait on the outcome of ReactiveCocoa/ReactiveCocoa#3470 to decide whether to merge this—thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants