Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

docs (operators): add documentation for ignoreElements #301

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

saiprasad2595
Copy link
Contributor

close #93

@rxjs-bot
Copy link

rxjs-bot commented Mar 17, 2018

Fails
🚫

commit message does not follows conventional change log (1)

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by 🚫 dangerJS

@saiprasad2595
Copy link
Contributor Author

Hi @ashwin-sureshkumar I think i have an extra space after type can you squash my commit and re-correct it I am facing some problem.Also please review it and let me know for any changes.

Thanks.

Copy link
Collaborator

@btroncone btroncone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few updates needed. 👍

{
name: 'Displaying Error',
code: `
//emit value every 100ms
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to update this to pipeable operators and remove global? Thanks!

const source = Rx.Observable.interval(100);
//ignore everything but error
const error = source
.flatMap(val => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use mergeMap here for consistency?

marbleUrl: 'http://reactivex.io/rxjs/img/ignoreElements.png',
shortDescription: {
description:
'Ignores all items emitted by the source Observable and only passes calls of `complete` or `error`'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to remove backticks here and use markdown-code class.

@saiprasad2595
Copy link
Contributor Author

@btroncone Sorry i was sick could not push. I have updated the file with flatMap with mergeMap for consistency and used markdown class for 'complete' and 'error'.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for operator : filtering - ignoreElements
3 participants