-
Notifications
You must be signed in to change notification settings - Fork 62
docs(i18n-zh): translate combination operators #310
base: master
Are you sure you want to change the base?
Conversation
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 116 116
Lines 445 445
Branches 9 9
=======================================
Hits 404 404
Misses 40 40
Partials 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it looks mostly good but I am not able to proof the translations :D But really thank you for your contribution.
import { fromEvent } from 'rxjs/observable/fromEvent'; | ||
|
||
const clicks = fromEvent(document, 'click'); | ||
const higherOrder = clicks.pipe( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add the expected output as comment and a $ as variable postfix for observables. Could you change this also for the following examples...
parameters: [ | ||
{ | ||
name: 'input1', | ||
type: 'ObservableInput', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it just an observable?
@SangKa do you know someone who could check your translations? |
The Chinese translation of combination operators are done.