Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

docs(i18n-zh): translate combination operators #310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SangKa
Copy link

@SangKa SangKa commented Apr 12, 2018

The Chinese translation of combination operators are done.

@SangKa SangKa mentioned this pull request Apr 12, 2018
10 tasks
@rxjs-bot
Copy link

rxjs-bot commented Apr 12, 2018

Warnings
⚠️

❗ Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Apr 12, 2018

Codecov Report

Merging #310 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         116      116           
  Lines         445      445           
  Branches        9        9           
=======================================
  Hits          404      404           
  Misses         40       40           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4097607...3ca0fb7. Read the comment docs.

Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it looks mostly good but I am not able to proof the translations :D But really thank you for your contribution.

import { fromEvent } from 'rxjs/observable/fromEvent';

const clicks = fromEvent(document, 'click');
const higherOrder = clicks.pipe(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add the expected output as comment and a $ as variable postfix for observables. Could you change this also for the following examples...

parameters: [
{
name: 'input1',
type: 'ObservableInput',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it just an observable?

@niklas-wortmann
Copy link
Member

@SangKa do you know someone who could check your translations?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants