-
Notifications
You must be signed in to change notification settings - Fork 62
feat(route getting started page): getting started page #43
base: master
Are you sure you want to change the base?
feat(route getting started page): getting started page #43
Conversation
@btroncone @kwonoj can one of you two approve review so we can get this merged? thanks! and thanks @arat3091! <3 |
Split descriptions for combineAll and combineLatest between two lines to satisfy lint requirement (line +140 chars)
feat(operators): operator browser page
- Added basic tooling configuration for linting using prettier, tslint. - Added precommit to run lint on staged files Close ReactiveX#45
chore(tooling): Add prettier, lint-staged and precommit hook for tooling
chore(danger): fix dangerfile
chore(travis): update build coverage config
router for the getting started page and link to andre staltz page ReactiveX#33
removing test ReactiveX#33
Review comments by the members ReactiveX#33
merge from upstrem master ReactiveX#33
removing test ReactiveX#33
…com/arat3091/rxjs-docs into arat3091/pr33-getting-started-guide
adding formating ReactiveX#33
@ladyleet .. hope you doing good .. i just merged from master to this branch now so that you can easily merge ... |
I am lost on DANGER_GITHUB_API_TOKEN ... can anyone help ? |
It's not token issue. check #43 (comment) 's warning and failure. |
@kwonoj .. but i am not able to find the problem. i am follwing as it says ..my commit message says body issue number link |
guide for starters none
Hi @ladyleet or @kwonoj or @btroncone , can you help me in merging this one . I have no idea y my commit message fails. I am trying to follow the same as stated in the guideline. |
hmm... @ashwin-sureshkumar or @btroncone can you guys help with this for @arat3091 ? |
@ashwin-sureshkumar if you have time to help with this! // @btroncone @sumitarora |
@arat3091 the issue seems to come from the commit
and then edit the offending commit message and force push. I can give it a shot on a separate branch if you prefer. |
@xlozinguez @arat3091 - Any progress on this PR ? Please rebase as well. |
is there any way to get this pr merged? If there is any way to provide some help or something like that, just let me know. |
route for the getting started page and link to andre staltz page
#33