Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

feat(route getting started page): getting started page #43

Open
wants to merge 74 commits into
base: master
Choose a base branch
from

Conversation

arat3091
Copy link

route for the getting started page and link to andre staltz page

#33

@ladyleet
Copy link
Member

@btroncone @kwonoj can one of you two approve review so we can get this merged? thanks! and thanks @arat3091! <3

btroncone and others added 17 commits October 20, 2017 10:06
Split descriptions for combineAll and combineLatest between two lines to satisfy lint requirement
(line +140 chars)
feat(operators): operator browser page
- Added basic tooling configuration for linting using prettier, tslint.
- Added precommit to run lint on staged files

Close ReactiveX#45
chore(tooling): Add prettier, lint-staged and precommit hook for tooling
chore(travis): update build coverage config
router for the getting started page and link to andre staltz page

ReactiveX#33
merge from upstrem master

ReactiveX#33
@arat3091
Copy link
Author

@ladyleet .. hope you doing good .. i just merged from master to this branch now so that you can easily merge ...

@arat3091
Copy link
Author

I am lost on DANGER_GITHUB_API_TOKEN ... can anyone help ?

@kwonoj
Copy link
Member

kwonoj commented Oct 23, 2017

It's not token issue. check #43 (comment) 's warning and failure.

@arat3091
Copy link
Author

@kwonoj .. but i am not able to find the problem. i am follwing as it says ..my commit message says
feat(subject): some content

body

issue number link

@arat3091
Copy link
Author

Hi @ladyleet or @kwonoj or @btroncone , can you help me in merging this one . I have no idea y my commit message fails. I am trying to follow the same as stated in the guideline.

@ladyleet
Copy link
Member

hmm... @ashwin-sureshkumar or @btroncone can you guys help with this for @arat3091 ?

@ladyleet
Copy link
Member

@ashwin-sureshkumar if you have time to help with this! // @btroncone @sumitarora

@xlozinguez
Copy link

@arat3091 the issue seems to come from the commit 47bf72c1d3ebb9630a3eab49d900334529edc71c, I would suggest you try the following:

  git rebase -i HEAD~3

and then edit the offending commit message and force push. I can give it a shot on a separate branch if you prefer.

@ashwin-sureshkumar
Copy link
Collaborator

ashwin-sureshkumar commented Dec 4, 2017

@xlozinguez @arat3091 - Any progress on this PR ? Please rebase as well.

@niklas-wortmann
Copy link
Member

is there any way to get this pr merged? If there is any way to provide some help or something like that, just let me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants