feat(windowWith): rename window to windowWith #5335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-galas
changed the title
artem-galas
changed the title
added 2 commits
March 22, 2020 10:37
|
After the Core Team meeting: I'm not sure I like this name anymore, haha sorry @artem-galas... we're going to punt on this one for a bit and revisit it later. Not closing, just punting. |
|
Closing this for now. As stated above, we'll revisit this change later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since window might have conflict with global window object, rename
windowtowindowWithRelated issue (if exists):
#5296