-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/images #48
Open
RohanCruickshank
wants to merge
35
commits into
develop
Choose a base branch
from
feature/images
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/images #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update required config settings
- Create database controller framework - Create script for tests
- Link with commandController - Add mongoose types for Typescript
- Link with timesheet reminder and time reports - Update help with commands - Add the local image folder to the git-ignore
…the removal of unwanted ones (when removal is implemented)
- Add help text for !images getall <type> command
- Update commandController's mock builder to include recently added functions
- Restructure getImage to allow specific images to be gotten (currently overwrites the current day's image) - Add more logging to Discord so that users know that stuff is happening
… from being added to the database
- Yet to cover a successful result
- mock database to allow for interaction testing
… database at the same time
…even if there's no database - Add checks into databaseController to check that the database is connected before trying to access it - Try to optimise tests // For some reason a simple test is taking a full second to complete (Throw an exception)...
…empt to the docker mongoDB
…the same time the connection is made
…it to miss the catch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.