feat: Amped Finance #43
Conversation
AmpedFinance
changed the title
projects/amped/functions/example.ts
Outdated
| * @returns Transaction result | ||
| */ | ||
| export async function example({ chainName, account, amount }: Props, { notify, getProvider }: FunctionOptions): Promise<FunctionReturn> { | ||
| // Validate chain |
There was a problem hiding this comment.
ok, but we need remove example from prod
| }, | ||
| ], | ||
| required: ['chainName', 'account', 'tokenIn'], | ||
| parameters: { |
There was a problem hiding this comment.
#36 (comment) you can't omit optional args
There was a problem hiding this comment.
Ok, yes I think these were treated as optional as we default them to a null value if not provided
I have included each of these arguments as required now
| }) as bigint; | ||
|
|
||
| await notify(`Native price: ${nativePrice.toString()}`); | ||
|
|
There was a problem hiding this comment.
Pls change this. notify(Native price: ${nativePrice.toString()}); for notify(Native price from Amped Finance: ${nativePrice.toString()});
|
|
||
| // Price is in 1e30, balance in 1e18, result should be in USD | ||
| const nativeBalanceUsd = (Number(nativeBalanceBigInt) * Number(nativePrice)) / 1e48; | ||
|
|
There was a problem hiding this comment.
you have problem here. JavaScript Number (IEEE 754) cannot accurately represent values beyond 2^53 - 1 (~9 quadrillion). Consider use bigint
| const nativeBalanceUsd = (Number(nativeBalanceBigInt) * Number(nativePrice)) / 1e48; | ||
|
|
||
| await notify(`Native balance USD: ${nativeBalanceUsd}`); | ||
|
|
| abi: ERC20, | ||
| functionName: 'balanceOf', | ||
| args: [account], | ||
| }) as bigint; |
There was a problem hiding this comment.
you can use multicall or await Promise.all
There was a problem hiding this comment.
Good call, updated to use Promise.all
| }) as bigint; | ||
|
|
||
| // Price is in 1e30, balance in token decimals, result should be in USD | ||
| const balanceUsd = (Number(balance) * Number(price)) / (Math.pow(10, token.decimals) * 1e30); |
| */ | ||
| export async function addLiquidity( | ||
| { chainName, account, tokenSymbol, amount, percentOfBalance = 25, minUsdg = '0', minGlp = '0' }: Props, | ||
| { getProvider, notify, sendTransactions }: FunctionOptions, |
There was a problem hiding this comment.
it's not really good way by default without any warning ask 25% of balance from user. Suggest change percentOfBalance from optional to required and ask user input proper amount.
There was a problem hiding this comment.
Good point, I think this was implemented this way for testing purposes.
We have now asked that the user provide either a % of the token balance or an exact amount
| // Warn if price impact is high | ||
| if (priceImpact > 1) { | ||
| await notify(`Warning: High price impact (${priceImpact.toFixed(2)}%). Consider reducing the amount.`); | ||
| } |
There was a problem hiding this comment.
thx for adding necessary checks. Rest, almost all don't do this.
| const provider = getProvider(chainId); | ||
|
|
||
| // Check token approval if not native token | ||
| if (tokenIn !== CONTRACT_ADDRESSES[NETWORKS.SONIC].NATIVE_TOKEN) { |
There was a problem hiding this comment.
you treat wrapped as native, so actually you NEED approve in that case too. Isn't it?
There was a problem hiding this comment.
You make a good point, I was implementing NATIVE as wrapped native. I have separated the two tokens now.
adding S as liquidity as native token is fine
adding wS will check for approval before adding to the pool
| await notify('Checking token approval...'); | ||
|
|
||
| // Check current allowance for RewardRouterV2 | ||
| const allowance = await provider.readContract({ |
There was a problem hiding this comment.
just use checkApprove function. This function check allowance and add to transaction array tx for approve and return transaction array for your function for further fill.
| await notify(`Approval transaction submitted. Waiting for confirmation...`); | ||
|
|
||
| // Wait for approval to be confirmed before proceeding | ||
| await provider.waitForTransactionReceipt({ hash: approvalTx.data[0].hash }); |
There was a problem hiding this comment.
you definitely don't need do this waitForTransactionReceipt
| // Prepare transaction data | ||
| const txData: TransactionParams = { | ||
| target: CONTRACT_ADDRESSES[NETWORKS.SONIC].REWARD_ROUTER, | ||
| value: tokenIn === CONTRACT_ADDRESSES[NETWORKS.SONIC].NATIVE_TOKEN ? parsedAmount : 0n, |
There was a problem hiding this comment.
if you need work with native you can use const NATIVE_ADDRESS: "0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE". Are you sure that you don't have here problem for sending msg.value?
There was a problem hiding this comment.
I added the native address to handle separately now
|
|
||
| // Send transaction | ||
| await notify('Executing transaction...'); | ||
| const txResult = await sendTransactions({ |
There was a problem hiding this comment.
anon-integration-guide/projects/wagmi/functions/stake.ts
Lines 75 to 98 in 8864932
|
|
||
| try { | ||
| const publicClient = getProvider(chainId); | ||
| const amountInWei = parseUnits(amount, 18); |
There was a problem hiding this comment.
consider check amountInWei > 0n
Amped Finance Integration
Description
Implementation of Amped Finance perpetual swaps and AMM exchange integration:
Core Features
✅ Liquidity Operations
✅ Leveraged Trading
✅ Information Services
✅ Risk Management
Technical Improvements
Enhanced error handling with contextual messages
Robust input validation for financial operations
Type-safe implementations for core operations
Gas-optimized transaction building
Comprehensive response formatting
Supported Networks
Sonic (Mainnet)
Test Results
All core test suites passing (6/6):
Implementation Details
Modular architecture with separated concerns:
Features
Next Steps
References
Amped Finance
Protocol Type: Decentralized Perpetual Exchange
Twitter: @AmpedFinance
Documentation: https://amped.gitbook.io/amped/