Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-35562: Update compose files to be compatible with podman-compose on Fedora #694

Conversation

catastrophe-brandon
Copy link
Contributor

@catastrophe-brandon catastrophe-brandon commented Oct 2, 2024

Updates:

  1. Referred to database container by container hostname (podman uses a "trick" to resolve these hostnames, so they need to be used consistently)
  2. Added a hard-coded sleep before unleash_web tries to interact with postgres db. (health checks are no longer honored by compose as part of "depends_on"). See Fails to handle the service_healthy condition of a depends_on element containers/podman-compose#866 for details.
  3. Various ports are configurable via .env:
    a. UNLEASH_WEB_PORT
    b. ZOOKEEPER_CLIENT_PORT
    c. KAFKA_JMX_PORT
    d. KAFKA_CLIENT_LISTEN_PORT
    e. KAFKA_CLIENT_LISTEN_PORT_2

Note: Configuration via env only applies to the external port configuration of the pod. Env file changes will not affect pod internal port configurations for components. These changes were made to help devs prevent collisions with listen ports that may be in-use on their local systems.

@catastrophe-brandon catastrophe-brandon force-pushed the btweed/podman-compose-unleash branch from 2fbbc1c to c215d47 Compare October 2, 2024 16:28
@catastrophe-brandon catastrophe-brandon changed the title Add unleash compose files compatible with podman-compose Update compose files to be compatible with podman-compose on Fedora Oct 2, 2024
@Hyperkid123
Copy link
Contributor

@catastrophe-brandon we will probably also need some env variables for the WebPort and Metrics ports configurations. The defaults can be occupied and my system is dying on that with these changes.

@catastrophe-brandon catastrophe-brandon changed the title Update compose files to be compatible with podman-compose on Fedora RHCLOUD-35562: Update compose files to be compatible with podman-compose on Fedora Oct 3, 2024
@Hyperkid123 Hyperkid123 merged commit eef5a7b into RedHatInsights:main Oct 9, 2024
8 checks passed
@catastrophe-brandon catastrophe-brandon deleted the btweed/podman-compose-unleash branch October 9, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants