Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification Drawer Update #2571
Notification Drawer Update #2571
Changes from 17 commits
5b08115
c4caa32
04fd7ee
6c900fd
a0e0e01
aa4c288
dda00c8
e3bfecf
a4b8c21
e140689
354f354
f30a632
bcaa731
9362cd6
58dcec0
d40694e
7937934
41f50d5
351ba96
e9d3834
668c93f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkbox is partially uncontrolled which prints an error in a console.
There is a build in PF way of creating menu item checkboxes: https://www.patternfly.org/components/menus/menu
DropdownItem shares props with MenuItems. It's just a wrapper around it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I misunderstood what you meant with the menu wrapper before 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dropdown is missing the
onOpenChange
prop to properly react to click events. You are also missing thepopperProps
config to ensure the dropdown menu is not hiding behind the edge of the screen.