Use newest stable node version #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelhala
requested review from
Hyperkid123,
ryelo and
florkbr
as code owners
karelhala
force-pushed
the
use-latest-node-stable
branch
2 times, most recently
from
e83effc to
f10ebbd
Compare
Hyperkid123
reviewed
Sep 5, 2023
.travis.yml
Outdated
| notifications: | ||
| email: false | ||
| slack: | ||
| secure: 'd3g5oKl5kfzi2L96QTrj2g77lzLWzjnM6Ct2OTXRrk90GxxhwHS8RH4Q1IgBqkQjw68nkq7CNE9oAs+pt3si8kT4GQ164YLoTMVkDPBGOoOoMACPyanxQOEluUfdLEDIzChy/7EdlY3l1J2IM+lOK4e95jUwsT9BSXBsSladP++1EUiZfon9JcQSiSZa0e1/cVxLpEDuBB2cruUSTZ9sUATe/XZ0uH1EGzrooQJMkRgdty5UyNSsMxkvAY0Haivq8u9/gWAsLar0bA/90M5CVK7yohh9fY9UfTUbXVqwR3dFAXuW+SURrFVnPAX4FLZt/D09cg/CVCvoasiZdNi9RAeKOCfN+FoxB2ZJNnuM+4KDJX3dxnatd/stmEH1bcd75i4mh9zOWE1HX5d23HuZ4sKdDPpvhG3l7SpZfhLv0/EKL10ld9RdIaiTO2uPI3rsoyDeArzeV+09+dbB1iPKnS/3/Iw5KLhbew3mdJXKVfRk6KYcJySjT8EltrNy5Y7mty7/JzWssSpIpkMCnu6RGAtXO2v/jUfFm1WvsKK5BeH5efbLi1sjMNbVTeA3Bp8pvRPuw+50l94uDfeQ1HUTrq5zKXMUaG9dTdaYZX4fEDMmrbM1TLudjb9Xj4elaA5ioBH0gRFxAnSVTmrKFtFoCRVaqfmj3ceqxttCLUpkfvI=' | ||
| node_js: | ||
| - '16' | ||
| - '20.6.0' |
There was a problem hiding this comment.
Can we use v18? Its the current LTS
karelhala
force-pushed
the
use-latest-node-stable
branch
from
f10ebbd to
9fa260c
Compare
karelhala
force-pushed
the
use-latest-node-stable
branch
from
9fa260c to
4899162
Compare
Codecov Report
@@ Coverage Diff @@
## master #2632 +/- ##
==========================================
+ Coverage 52.10% 57.38% +5.28%
==========================================
Files 91 91
Lines 2451 2783 +332
Branches 447 570 +123
==========================================
+ Hits 1277 1597 +320
- Misses 810 1185 +375
+ Partials 364 1 -363
|
|
/retest |
1 similar comment
|
/retest |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.