-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable] Update build #2640
Merged
Merged
[stable] Update build #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Hyperkid123,
ryelo,
karelhala and
florkbr
as code owners
September 13, 2023 09:40
Can one of the admins verify this patch? |
Fix header tools notifications badge spacing.
Hook notifications drawer to chrome-services websockets
Fix notifications data undefined in ephem
Codecov Report
@@ Coverage Diff @@
## master-stable #2640 +/- ##
=================================================
+ Coverage 57.19% 57.47% +0.28%
=================================================
Files 92 93 +1
Lines 2815 2843 +28
Branches 661 582 -79
=================================================
+ Hits 1610 1634 +24
- Misses 1130 1208 +78
+ Partials 75 1 -74
|
Add Icon support for service dropdown
* Completing first pass on test suite. * Wrapping user actions and expects for async. * Switching to title in notification labels. * Fixing all console errors related async acts. * Changing test ids to strings
Remove unnecessary sentry code from prod build.
RHCLOUD-28582 add tooltip for notifications badge
Update PF and FEC to latest stable versions.
/ok-to-test |
Co-authored-by: Karel Hala <[email protected]>
Co-authored-by: Karel Hala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.