Add Icon support for service dropdown #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwinchell
requested review from
Hyperkid123,
ryelo,
karelhala and
florkbr
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2641 +/- ##
==========================================
- Coverage 57.23% 52.56% -4.68%
==========================================
Files 92 93 +1
Lines 2825 2496 -329
Branches 661 451 -210
==========================================
- Hits 1617 1312 -305
+ Misses 1133 816 -317
- Partials 75 368 +293
|
epwinchell
force-pushed
the
Services_icons
branch
5 times, most recently
from
965ae01 to
38e99c2
Compare
Hyperkid123
requested changes
Sep 22, 2023
epwinchell
force-pushed
the
Services_icons
branch
from
38e99c2 to
089739d
Compare
epwinchell
force-pushed
the
Services_icons
branch
from
2aef6f7 to
b3671ae
Compare
epwinchell
force-pushed
the
Services_icons
branch
from
08e9f14 to
f5098c4
Compare
|
\retest |
Hyperkid123
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/RHCLOUD-28103
Depends on: RedHatInsights/chrome-service-backend#281