Update Search empty state #2975
Conversation
epwinchell
requested review from
Hyperkid123,
ryelo,
karelhala and
florkbr
as code owners
| EmptyStateHeader, | ||
| EmptyStateIcon, | ||
| } from '@patternfly/react-core/dist/dynamic/components/EmptyState'; | ||
| // import { Button } from '@patternfly/react-core/dist/dynamic/components/Button'; |
There was a problem hiding this comment.
Can you remove the commented code?
There was a problem hiding this comment.
@Hyperkid123 We have two buttons that need to be activated in follow-up PRs/Jira and all the styling has been done here. Can we leave it all in? Otherwise, there's not much point to this PR cc @fhlavac
There was a problem hiding this comment.
We need https://issues.redhat.com/browse/RHCLOUD-36235 to activate the Launch button. @Hyperkid123 can you please take a look if anything needs to be added to the ticket? If it is good, I could do it to unblock this one (I know it's Chrome UI, so if you or the Services team have capacity, we can also assign it to someone else).
There was a problem hiding this comment.
I don't see any reason why you could not work on it.
| </TextContent> | ||
| </EmptyStateBody> | ||
| {/* <EmptyStateFooter className="pf-v5-u-mt-md"> |
Jira: https://issues.redhat.com/browse/RHCLOUD-36187
Old
New
