Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentry: stop avoiding the image-builder app #2980

Merged
merged 1 commit into from
Nov 20, 2024
Merged

sentry: stop avoiding the image-builder app #2980

merged 1 commit into from
Nov 20, 2024

Conversation

croissanne
Copy link
Contributor

Image builder now uploads sourcemaps and sends everything into a separate project as we set the DSN in the module metadata.

@croissanne
sentry: stop avoiding the image-builder app
0586e1e 
Image builder now uploads sourcemaps and sends everything into a
separate project as we set the DSN in the module metadata.
adonispuente
adonispuente approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@adonispuente adonispuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hyperkid123 Hyperkid123 requested a review from a team November 19, 2024 08:40
justinorringer
justinorringer approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@justinorringer justinorringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. I'm curious about the size of data/how often we send it to sentry btw, let me know if you all get some numbers

@Hyperkid123 Hyperkid123 merged commit 75f99cf into RedHatInsights:master Nov 20, 2024
11 of 13 checks passed
@croissanne croissanne deleted the sentry-dontavoid branch November 20, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinorringer justinorringer justinorringer approved these changes

@adonispuente adonispuente adonispuente approved these changes

@Hyperkid123 Hyperkid123 Awaiting requested review from Hyperkid123 Hyperkid123 is a code owner

@ryelo ryelo Awaiting requested review from ryelo ryelo is a code owner

@karelhala karelhala Awaiting requested review from karelhala karelhala is a code owner

@florkbr florkbr Awaiting requested review from florkbr florkbr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@croissanne @adonispuente @justinorringer @Hyperkid123