MAS Patches #120
Open
MAS Patches #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riprasad
commented
Feb 10, 2023
| export APP_NAME=$(node -e "console.log(require(\"${WORKSPACE:-.}${APP_DIR:-}/package.json\").insights.appname)") | ||
| export CONTAINER_NAME="$APP_NAME-build-main" | ||
| # Flexibilty to provide APP_NAME from pr_check.sh parent file. | ||
| export APP_NAME=${APP_NAME:=$(node -e "console.log(require(\"${NODE_ROOT}/package.json\").insights.appname)")} |
There was a problem hiding this comment.
MAS Jenkins instances doesn;t have node installed. so the pipeline fails at this step.
riprasad
commented
Feb 10, 2023
| DOCKER_CONF="$PWD/.docker" | ||
| mkdir -p "$DOCKER_CONF" | ||
|
|
||
| if [ $QUAY_ORG == "rhoas" ] ; then |
There was a problem hiding this comment.
All our images are in RHOAS org, so we want to push our images there.
riprasad
commented
Feb 10, 2023
| @@ -83,6 +117,9 @@ docker run -i --name $CONTAINER_NAME \ | |||
| -e SERVER_NAME=$SERVER_NAME \ | |||
| -e INCLUDE_CHROME_CONFIG \ | |||
| -e CHROME_CONFIG_BRANCH \ | |||
| -e APP_NAME=$APP_NAME \ | |||
There was a problem hiding this comment.
Flexibility to specify APP_NAME, SERVER_NAME and DIST_DIR from parent pr_check.sh file.
related PR: https://gitlab.cee.redhat.com/insights-platform/frontend-build-container/-/merge_requests/24
|
@adamrdrew Please review |
|
I will take a look at this today. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAS Jenkins instances doesn't have node installed. hence cannot fetch App name from package.json. This change provides flexibility to:-