Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-27273] Enforce correct value/operation pairings #1418

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[RHCLOUD-27273] Enforce correct value/operation pairings #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5fe04f3
validate operation/value pairings
mjholder Jan 3, 2025
6292dd5
test new validations
mjholder Jan 3, 2025
de6b353
linting
mjholder Jan 3, 2025
8549be3
linting
mjholder Jan 6, 2025
8f684dd
check using isinstance
mjholder Jan 6, 2025
d5d3c2a
check inverse
mjholder Jan 6, 2025
8c044ab
more precise error assertion
mjholder Jan 6, 2025
05d1b6c
Merge branch 'master' into correct-attribute-filter
lpichler Jan 21, 2025
fe0950e
Merge branch 'master' into correct-attribute-filter
lpichler Jan 22, 2025
751e3b7
Merge branch 'master' into correct-attribute-filter
lpichler Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions rbac/management/role/serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,19 @@ def validate_attributeFilter(self, value):
message = f"attributeFilter operation must be one of {ALLOWED_OPERATIONS}"
error = {key: [_(message)]}
raise serializers.ValidationError(error)
else:
values = value.get("value")
error = False
if not isinstance(values, list) and op == "in":
key = "format"
message = "attributeFilter operation 'in' expects a List value"
error = {key: [_(message)]}
elif isinstance(values, list) and op == "equals":
key = "format"
message = "attributeFilter operation 'equals' expects a String value"
error = {key: [_(message)]}
if error:
raise serializers.ValidationError(error)
return value

class Meta:
Expand Down
Loading
Loading