[RHCLOUD-37936] refactored /principals/ endpoint by splitting it into separate methods

[petracihalova]

Link(s) to Jira

• RHCLOUD-37936

Description of Intent of Change(s)

motivation: some cleanup before I will start the work on the adding principal_type=all query param option to list both principal types with GET /groups/<uuid>/principals/ endpoint

Refactored /principals/ endpoint by splitting it into separate methods

• get_principals for retrieving group principals (GET)
• add_principal for adding a principal to a group (POST)
• remove_principal for removing a principal from a group (DELETE)

the principals metod started to be huge and complicated

def principals(self, request: Request, uuid: Optional[UUID] = None):
    if request.method == "POST":
        ... logic for POST
    elif request.method == "GET":
        ... logic for GET
    else:
        ... logic for DELETE
    return response

so I created new methods for each HTTP method and then redirected the requests from principals()

@action(detail=True, methods=["get", "post", "delete"])
def principals(self, request: Request, uuid: Optional[UUID] = None):
    """Alias for individual methods based on the HTTP method."""
    if request.method == "GET":
        return self.get_principals(request, uuid)
    elif request.method == "POST":
        return self.add_principal(request, uuid)
    elif request.method == "DELETE":
        return self.remove_principal(request, uuid)
    return Response({"error": "Method not allowed"}, status=status.HTTP_405_METHOD_NOT_ALLOWED)

def get_principals(self, request: Request, uuid: Optional[UUID] = None):
    """Get principals from a group."""
   ... logic for GET

def add_principal(self, request: Request, uuid: Optional[UUID] = None):
    """Add a principal to a group."""
    ... logic for POST

def remove_principal(self, request: Request, uuid: Optional[UUID] = None):
    """Remove a principal from a group."""
    ... logic for DELETE

there is no need to add tests or update open api spec because there is no logic change

Local Testing

run the unit tests

[Ellen-Yi-Dong]

LGTM!

Locally tested with unit tests as mentioned in description and everything worked as expected on my end!!

[petracihalova]

/retest