Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHINENG-2394: allow Kafka TLS without CA cert #1318

Merged
merged 1 commit into from
Oct 4, 2023
Merged

RHINENG-2394: allow Kafka TLS without CA cert #1318

merged 1 commit into from
Oct 4, 2023

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Oct 4, 2023

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking
Copy link

jira-linking bot commented Oct 4, 2023

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-2394

@psegedy psegedy requested a review from MichaelMraka October 4, 2023 09:04
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files Coverage Δ
base/database/utils.go 7.69% <100.00%> (ø)
base/utils/config.go 65.26% <100.00%> (+0.42%) ⬆️
base/database/testing.go 10.46% <0.00%> (ø)
base/mqueue/mqueue_impl_gokafka.go 60.22% <42.85%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@psegedy psegedy changed the title RHINENG-2394: allow Kafka TLS withous CA cert RHINENG-2394: allow Kafka TLS without CA cert Oct 4, 2023
@psegedy
Copy link
Member Author

psegedy commented Oct 4, 2023

/retest

@psegedy psegedy merged commit 92c4131 into RedHatInsights:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelMraka MichaelMraka MichaelMraka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psegedy @codecov-commenter @MichaelMraka