Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation #1338

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Deprecation #1338

merged 6 commits into from
Nov 10, 2023

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Nov 8, 2023

  • Generic Deprecation interface for future deprecations
  • API Deprecation struct for deprecation of whole api version or single endpoint
    • Set Deprecation and Sunset headers
    • 301 Redirect after redirectTimestamp, redirect location can be set either by providing redirectLocation or by modifying the current location with redirectReplacer
    • 401 Gone after deprecationTimestamp
  • Deprecation middleware
  • Deprecation of /v1 and /v2 api versions
    • Deprecation and Sunset headers set to 2024-01-31
    • 301 Redirect to /v3 since 2024-01-01
    • 401 Gone returned since 2024-01-31
  • Set v1 and v2 as deprecated in docs/{v1|v2}/openapi.json

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Nov 8, 2023

Commits missing Jira IDs:
a614115
ddd1e98
Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-3104

@psegedy psegedy force-pushed the deprecation branch 3 times, most recently from 9c4f07a to 0f99fc9 Compare November 9, 2023 17:44
@psegedy psegedy marked this pull request as ready for review November 9, 2023 17:44
@psegedy psegedy requested a review from MichaelMraka November 9, 2023 17:45
@psegedy psegedy merged commit 44cb6b9 into RedHatInsights:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants