Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-3742: Multiple kafka brokers #1341

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Nov 20, 2023

  • we need to use multiple kafka brokers - use KafkaServers for that
  • we probably no longer need to overwrite KAFKA_ADDRESS, it doesn't seem to be used anywhere
  • handle Endpoint and PrivateEndpoint separately, structs are no longer equivalent after latest changes in Clowder (Enfpoint has extra ApiPath field and we can't convert PrivateEndpoint to Endpoint 😞 )

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Nov 20, 2023

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-3742

@psegedy psegedy merged commit 75a3cde into RedHatInsights:master Nov 20, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants