Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: remove json from system_packages table #1342

Merged
merged 30 commits into from
Dec 5, 2023
Merged

POC: remove json from system_packages table #1342

merged 30 commits into from
Dec 5, 2023

Conversation

MichaelMraka
Copy link
Collaborator

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (25f765e) 61.82% compared to head (b5132b9) 62.03%.
Report is 1 commits behind head on master.

Files Patch % Lines
evaluator/evaluate_packages.go 85.13% 6 Missing and 5 partials ⚠️
base/database/testing.go 0.00% 4 Missing ⚠️
manager/controllers/system_packages_export.go 66.66% 3 Missing ⚠️
base/database/utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
+ Coverage   61.82%   62.03%   +0.20%     
==========================================
  Files         108      108              
  Lines        6814     6811       -3     
==========================================
+ Hits         4213     4225      +12     
+ Misses       2062     2052      -10     
+ Partials      539      534       -5     
Flag Coverage Δ
unittests 62.03% <81.98%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy force-pushed the poc branch 7 times, most recently from b5a0ccc to 3ff49e3 Compare November 27, 2023 18:11
@MichaelMraka MichaelMraka marked this pull request as ready for review December 5, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants