Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC2: precalculate data for /packages APIs #1343

Closed
wants to merge 15 commits into from
Closed

POC2: precalculate data for /packages APIs #1343

wants to merge 15 commits into from

Conversation

MichaelMraka
Copy link
Collaborator

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@MichaelMraka MichaelMraka force-pushed the poc2 branch 2 times, most recently from a4b6c7b to 13f4554 Compare November 22, 2023 12:26
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (997b6bc) 62.00% compared to head (a85afef) 61.32%.
Report is 1 commits behind head on master.

Files Patch % Lines
base/database/testing.go 0.00% 43 Missing ⚠️
evaluator/evaluate_packages.go 64.34% 31 Missing and 10 partials ⚠️
base/database/utils.go 0.00% 18 Missing ⚠️
manager/controllers/system_packages_export.go 72.72% 4 Missing and 2 partials ⚠️
manager/controllers/system_packages.go 75.00% 1 Missing and 1 partial ⚠️
manager/controllers/package_systems.go 91.66% 0 Missing and 1 partial ⚠️
manager/controllers/package_systems_export.go 75.00% 0 Missing and 1 partial ⚠️
tasks/caches/refresh_packages_caches.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
- Coverage   62.00%   61.32%   -0.68%     
==========================================
  Files         108      108              
  Lines        6811     6855      +44     
==========================================
- Hits         4223     4204      -19     
- Misses       2054     2113      +59     
- Partials      534      538       +4     
Flag Coverage Δ
unittests 61.32% <53.49%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelMraka MichaelMraka force-pushed the poc2 branch 2 times, most recently from 17953ed to 12b344b Compare December 8, 2023 09:25
@MichaelMraka
Copy link
Collaborator Author

This POC did not meet expectations, the evaluation part is significantly slower and small improvement in speed of /packages API is not going to overweight it.
Closing without merge into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants