fix failing golanci-lint #1344
Merged
fix failing golanci-lint #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMraka
force-pushed
the
pr1
branch
2 times, most recently
from
15eab3a to
79a937c
Compare
manager/controllers/baseline_delete.go:37:60: string `Invalid baseline_id: ` has 3 occurrences, make it a constant (goconst)
c.JSON(http.StatusBadRequest, utils.ErrorResponse{Error: "Invalid baseline_id: " + baselineIDstr})
tasks/vmaas_sync/advisory_sync_test.go:17:15: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
func TestInit(t *testing.T) {
^
base/utils/http.go:23:43: response body must be closed (bodyclose)
outDataPtr, resp, callErr := httpCallFun()
^
listener/common_test.go:23:15: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
func TestInit(t *testing.T) {
^
listener/common_test.go:80:28: unused-parameter: parameter 'rhAccountID' seems to be unused, consider removing or renaming it as _ (revive)
func createTestUploadEvent(rhAccountID, orgID, inventoryID, reporter string, packages, yum bool) HostEvent {
^
evaluator/evaluate_test.go:23:15: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
func TestInit(t *testing.T) {
^
manager/controllers/advisory_systems_v3.go:104:41: G601: Implicit memory aliasing in for loop. (gosec)
if err = parseSystemItems(as.TagsStr, &as.AdvisorySystemItemAttributes.Tags); err != nil {
^
manager/controllers/advisory_systems_v3.go:107:43: G601: Implicit memory aliasing in for loop. (gosec)
if err = parseSystemItems(as.GroupsStr, &as.AdvisorySystemItemAttributes.Groups); err != nil {
^
manager/controllers/package_systems.go:242:46: G601: Implicit memory aliasing in for loop. (gosec)
if err := parseSystemItems(system.TagsStr, &system.PackageSystemItemV3.Tags); err != nil {
^
manager/controllers/utils.go:477:28: unused-parameter: parameter 'code' seems to be unused, consider removing or renaming it as _ (revive)
func Csv(ctx *gin.Context, code int, res interface{}) {
^
MichaelMraka
changed the title
psegedy
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist