Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: migrate job improvements #1348

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Nov 24, 2023

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Nov 24, 2023

Commits missing Jira IDs:
b9ece7c
ee3ef3a

@psegedy psegedy marked this pull request as draft November 24, 2023 14:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fea3f04) 62.03% compared to head (ee3ef3a) 62.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##              poc    #1348   +/-   ##
=======================================
  Coverage   62.03%   62.03%           
=======================================
  Files         108      108           
  Lines        6811     6811           
=======================================
  Hits         4225     4225           
  Misses       2052     2052           
  Partials      534      534           
Flag Coverage Δ
unittests 62.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy marked this pull request as ready for review November 27, 2023 10:35
@psegedy psegedy changed the title POC: make sure we are querying nevra from cache with epoch POC: migrate job improvements Nov 27, 2023
@psegedy psegedy requested a review from MichaelMraka November 27, 2023 10:47
@psegedy psegedy merged commit 2b7cd4e into RedHatInsights:poc Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants