Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-6031: drop old system_package table (POC cleanup) #1356

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

MichaelMraka
Copy link
Collaborator

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Dec 12, 2023

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-6031

@MichaelMraka MichaelMraka requested a review from psegedy December 12, 2023 10:39
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (405aa35) 61.91% compared to head (db53b8d) 61.91%.
Report is 8 commits behind head on master.

Files Patch % Lines
base/database/testing.go 0.00% 10 Missing ⚠️
evaluator/evaluate_packages.go 73.68% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
- Coverage   61.91%   61.91%   -0.01%     
==========================================
  Files         108      108              
  Lines        6804     6813       +9     
==========================================
+ Hits         4213     4218       +5     
- Misses       2056     2060       +4     
  Partials      535      535              
Flag Coverage Δ
unittests 61.91% <54.54%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelMraka MichaelMraka force-pushed the pr1 branch 2 times, most recently from a5e79ff to 677cb8a Compare January 11, 2024 14:05
@MichaelMraka MichaelMraka marked this pull request as ready for review January 17, 2024 14:58
@MichaelMraka MichaelMraka merged commit 9d3a4a7 into RedHatInsights:master Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants