Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-3098: deprecate limit=-1 and limit>100 #1357

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Dec 15, 2023

  • set Deprecation, Sunset, and Warning headers if limit=-1 or limit>100 is used
  • respond with HTTP status 400 if limit=-1 or limit>100 is used after 2024-03-01
  • LIMIT_PAGE_SIZE=false can be used to bypass limit of the limit parameter

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Dec 15, 2023

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-3098

@psegedy psegedy requested a review from MichaelMraka December 15, 2023 11:17
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b713b5d) 61.98% compared to head (ad10c46) 62.13%.
Report is 1 commits behind head on master.

Files Patch % Lines
base/utils/gin.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
+ Coverage   61.98%   62.13%   +0.14%     
==========================================
  Files         108      108              
  Lines        6811     6801      -10     
==========================================
+ Hits         4222     4226       +4     
+ Misses       2055     2041      -14     
  Partials      534      534              
Flag Coverage Δ
unittests 62.13% <25.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy
Copy link
Member Author

psegedy commented Dec 15, 2023

/retest

@psegedy psegedy merged commit 953e901 into RedHatInsights:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants