Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHINENG-10747: limit=-1 is not allowed #1437

Merged
merged 1 commit into from
Jun 17, 2024
Merged

RHINENG-10747: limit=-1 is not allowed #1437

merged 1 commit into from
Jun 17, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Jun 17, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking Jira Linking
Copy link

jira-linking bot commented Jun 17, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-10747

@psegedy psegedy requested a review from MichaelMraka June 17, 2024 10:13
@MichaelMraka
Copy link
Collaborator

I'd also change
base/utils/gin.go:76: return errors.New("limit must not be less than 1, or should be -1 to return all items")

@psegedy psegedy merged commit 2564dc4 into RedHatInsights:master Jun 17, 2024
3 of 4 checks passed
@psegedy psegedy deleted the limitminusone branch June 17, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelMraka MichaelMraka MichaelMraka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psegedy @MichaelMraka