Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-9505: register system within candlepin #1443

Merged
merged 9 commits into from
Sep 10, 2024

Conversation

MichaelMraka
Copy link
Collaborator

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Jun 25, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-9505

@niyazRedhat
Copy link

/retest

4 similar comments
@niyazRedhat
Copy link

/retest

@niyazRedhat
Copy link

/retest

@mtclinton
Copy link

/retest

@mtclinton
Copy link

/retest

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 74.13793% with 15 lines in your changes missing coverage. Please review.

Project coverage is 65.02%. Comparing base (eed2081) to head (8c33cc4).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
manager/controllers/template_systems_update.go 71.73% 7 Missing and 6 partials ⚠️
manager/controllers/template_systems_delete.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
+ Coverage   65.01%   65.02%   +0.01%     
==========================================
  Files         114      114              
  Lines        7823     7877      +54     
==========================================
+ Hits         5086     5122      +36     
- Misses       2207     2218      +11     
- Partials      530      537       +7     
Flag Coverage Δ
unittests 65.02% <74.13%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelMraka
Copy link
Collaborator Author

/retest

@MichaelMraka MichaelMraka merged commit 0deb3f5 into RedHatInsights:master Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants