Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-8141: improve evaluation performance #1456

Closed
wants to merge 0 commits into from

Conversation

Dugowitch
Copy link
Contributor

Refactored in a way that all data is loaded and evaluated first. Then, all updates (and just the updates) are done in a single transaction. Furthermore, advisories are now processed like package have been.

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Jul 31, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-8141

@Dugowitch Dugowitch marked this pull request as ready for review July 31, 2024 08:32
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 81.78439% with 49 lines in your changes missing coverage. Please review.

Project coverage is 65.09%. Comparing base (aba05cd) to head (6c2f2bb).
Report is 1 commits behind head on master.

Files Patch % Lines
evaluator/evaluate_advisories.go 85.55% 17 Missing and 9 partials ⚠️
evaluator/evaluate.go 72.72% 8 Missing and 4 partials ⚠️
evaluator/evaluate_packages.go 72.00% 6 Missing and 1 partial ⚠️
base/database/utils.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1456      +/-   ##
==========================================
+ Coverage   64.83%   65.09%   +0.25%     
==========================================
  Files         114      114              
  Lines        7798     7810      +12     
==========================================
+ Hits         5056     5084      +28     
+ Misses       2216     2203      -13     
+ Partials      526      523       -3     
Flag Coverage Δ
unittests 65.09% <81.78%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dugowitch Dugowitch marked this pull request as draft July 31, 2024 13:53
@Dugowitch Dugowitch force-pushed the master branch 2 times, most recently from 6c2f2bb to 39dffbe Compare August 7, 2024 09:55
@Dugowitch Dugowitch marked this pull request as ready for review August 7, 2024 10:15
@psegedy
Copy link
Member

psegedy commented Aug 7, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants