Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-11978: fix missing metrics after evaluator refactor #1462

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Dugowitch
Copy link
Contributor

@Dugowitch Dugowitch commented Aug 15, 2024

Metric Changes Overview

  • introduce advisories-load and advisories-evaluate instead of the missing advisories-processing
  • similarly to lazy-package-save, add advisories-lazy-save
  • fix missing installable, applicable, and fixed counter updates

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Aug 15, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-11978

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.06%. Comparing base (5adb8a6) to head (ddbcbb4).
Report is 1 commits behind head on master.

Files Patch % Lines
evaluator/evaluate_advisories.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1462      +/-   ##
==========================================
+ Coverage   65.01%   65.06%   +0.05%     
==========================================
  Files         114      114              
  Lines        7804     7821      +17     
==========================================
+ Hits         5074     5089      +15     
- Misses       2205     2206       +1     
- Partials      525      526       +1     
Flag Coverage Δ
unittests 65.06% <88.23%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dugowitch Dugowitch requested a review from psegedy August 15, 2024 10:52
@Dugowitch Dugowitch marked this pull request as ready for review August 15, 2024 10:52
Copy link
Member

@psegedy psegedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but let's merge it after #1464

@psegedy psegedy merged commit 6e62b4a into RedHatInsights:master Aug 20, 2024
3 of 4 checks passed
@Dugowitch Dugowitch deleted the RHINENG-11978 branch September 26, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants