Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-9452: refactor error handling #1465

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Aug 16, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Aug 16, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-9452

@psegedy psegedy marked this pull request as draft August 16, 2024 15:56
@psegedy psegedy force-pushed the errors branch 2 times, most recently from 591a8ce to 897115e Compare August 19, 2024 14:39
@psegedy psegedy marked this pull request as ready for review August 19, 2024 14:44
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.56338% with 28 lines in your changes missing coverage. Please review.

Project coverage is 64.98%. Comparing base (36039a2) to head (bbb08c0).
Report is 1 commits behind head on master.

Files Patch % Lines
listener/upload.go 67.79% 14 Missing and 5 partials ⚠️
base/mqueue/mqueue.go 25.00% 3 Missing ⚠️
evaluator/evaluate.go 0.00% 3 Missing ⚠️
evaluator/evaluate_baseline.go 0.00% 1 Missing ⚠️
evaluator/remediations.go 66.66% 1 Missing ⚠️
manager/middlewares/authentication.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
- Coverage   65.00%   64.98%   -0.02%     
==========================================
  Files         114      114              
  Lines        7810     7812       +2     
==========================================
  Hits         5077     5077              
+ Misses       2208     2206       -2     
- Partials      525      529       +4     
Flag Coverage Δ
unittests 64.98% <60.56%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niyazRedhat
Copy link

/retest

1 similar comment
@niyazRedhat
Copy link

/retest

@psegedy psegedy merged commit 827a992 into RedHatInsights:master Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants