Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-11685: add temp debug logs for middleware #1467

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Dugowitch
Copy link
Contributor

@Dugowitch Dugowitch commented Aug 21, 2024

This needs to get debugged in stage because local/ephemeral uses platform mock. When the mock is used, gzipping works as expected.

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Aug 21, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-11685

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.00%. Comparing base (6434537) to head (a9f399e).
Report is 1 commits behind head on master.

Files Patch % Lines
manager/middlewares/limits.go 0.00% 4 Missing ⚠️
manager/middlewares/rbac.go 55.55% 3 Missing and 1 partial ⚠️
manager/middlewares/timeout.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
- Coverage   65.06%   65.00%   -0.07%     
==========================================
  Files         114      114              
  Lines        7827     7836       +9     
==========================================
+ Hits         5093     5094       +1     
- Misses       2208     2215       +7     
- Partials      526      527       +1     
Flag Coverage Δ
unittests 65.00% <33.33%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dugowitch Dugowitch marked this pull request as ready for review August 22, 2024 08:30
@Dugowitch Dugowitch requested a review from psegedy August 22, 2024 08:30
@Dugowitch
Copy link
Contributor Author

/retest

@psegedy psegedy merged commit 99c1466 into RedHatInsights:master Aug 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants