Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-11685: gzip middleware with logging #1471

Merged
merged 1 commit into from
Aug 28, 2024
Merged

RHINENG-11685: gzip middleware with logging #1471

merged 1 commit into from
Aug 28, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Aug 26, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@psegedy psegedy requested a review from Dugowitch August 26, 2024 09:57
Copy link

jira-linking bot commented Aug 26, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-11685

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.97%. Comparing base (827a992) to head (21087ae).
Report is 1 commits behind head on master.

Files Patch % Lines
manager/middlewares/gzip.go 0.00% 6 Missing ⚠️
manager/middlewares/rbac.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1471   +/-   ##
=======================================
  Coverage   64.96%   64.97%           
=======================================
  Files         114      115    +1     
  Lines        7833     7837    +4     
=======================================
+ Hits         5089     5092    +3     
- Misses       2213     2214    +1     
  Partials      531      531           
Flag Coverage Δ
unittests 64.97% <20.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy merged commit f40e6a8 into master Aug 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants