Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-10032: fix repack job db user #1479

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Dugowitch
Copy link
Contributor

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Sep 18, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-10032

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.06%. Comparing base (45c6c36) to head (2aea703).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1479      +/-   ##
==========================================
+ Coverage   65.03%   65.06%   +0.02%     
==========================================
  Files         114      114              
  Lines        7877     7877              
==========================================
+ Hits         5123     5125       +2     
+ Misses       2217     2215       -2     
  Partials      537      537              
Flag Coverage Δ
unittests 65.06% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dugowitch Dugowitch marked this pull request as ready for review September 18, 2024 12:19
Copy link
Member

@psegedy psegedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be possible that this won't help because admin user is probably not a superuser and the option to use regular user seems broken in pg_repack reorg/pg_repack#223
Can we use default postgres user? Try to look at how db migrations are performed, I think we're using the superuser there

@MichaelMraka
Copy link
Collaborator

MichaelMraka commented Sep 18, 2024

According to reorg/pg_repack#201 you may need to use pg_repack -k .
Edit: I see there is --no-superuser-check.

@Dugowitch Dugowitch requested a review from psegedy September 19, 2024 10:09
@Dugowitch Dugowitch changed the title RHINENG-10032: add migration to fix repack permissions RHINENG-10032: fix repack job db user Sep 19, 2024
@psegedy psegedy merged commit 5655bc6 into RedHatInsights:master Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants