RHINENG-13371: remove old package_data from advisory_metadata #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Referenced Jiras: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1493 +/- ##
=======================================
Coverage 65.03% 65.03%
=======================================
Files 114 114
Lines 7880 7880
=======================================
Hits 5125 5125
Misses 2216 2216
Partials 539 539
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -0,0 +1,2 @@ | |||
| delete from advisory_metadata am where package_data is json array = 'f' and not exists (select 1 from advisory_account_data aad where aad.advisory_id = am.id); | |||
There was a problem hiding this comment.
Suggested change
| delete from advisory_metadata am where package_data is json array = 'f' and not exists (select 1 from advisory_account_data aad where aad.advisory_id = am.id); | |
| delete from advisory_metadata am where package_data is not json array and not exists (select 1 from advisory_account_data aad where aad.advisory_id = am.id); |
| @@ -0,0 +1,2 @@ | |||
| delete from advisory_metadata am where package_data is json array = 'f' and not exists (select 1 from advisory_account_data aad where aad.advisory_id = am.id); | |||
| update advisory_metadata set package_data = null where package_data is json array = 'f'; | |||
There was a problem hiding this comment.
Suggested change
| update advisory_metadata set package_data = null where package_data is json array = 'f'; | |
| update advisory_metadata set package_data = null where package_data is not json array; |
psegedy
force-pushed
the
old_package_data
branch
from
59eb89c to
82ab3c9
Compare
MichaelMraka
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist